Giters

dannyconnell / vscode-make-apps-theme

A relaxed, easy-on-the-eyes VSCode Theme based on the Hybrid Next Theme

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CSS property names within Media Queries have the wrong text color

rowild opened this issue · comments

commented

Nice theme! Learned about it in you Youtube courses or a link from there. Thank you!

There are 2 things that would need improvement, though, IMO, if I may say so:

  1. On errors in the terminal, the text should be white.
    Screen Shot 2020-11-28 at 00 08 39

  2. CSS in media queries is colored differently then outside of media queries. The screenshow shows that "color" and "background" are grey within @media, but white outside.
    Screen Shot 2020-11-28 at 00 12 34
    Should stay the same, which is the case, when I deactive the theme:
    Screen Shot 2020-11-28 at 00 13 14

Would be awesome if you could improve that!!! Thanks!

commented

Any news on this one here?

commented

@rowild I'll look into the media query issue. I can't recreate the error issue. My errors are just red / white text on the grey background:
Screenshot 2020-12-31 at 14 53 34
Can you provide some simple steps that will allow me to see an error like that?
Also, what shell are you using? bash, zsh?

commented

@rowild Fixed the "color of CSS property names within Media Queries" issue and published to Extensions Store. Unable to recreate terminal error color issue. I suspect those terminal colors are being generated by whatever command line tool you're using, so I will close this issue. If I'm wrong & you can provide steps for me to recreate, please open a new issue. Let's keep separate issues separate. Cheers for you help.