FileUpload GraphQL Schema

Question

FileUpload GraphQL Schema

BenSlabbert opened this issue 4 years ago · comments

Ben commented 4 years ago

Hello! Thanks for a great repo!

From what I can see there is no support for the scalar type Upload?

Please see this example from 99designs.

Please let me know if I have made an error or if this is an opportunity for a PR :)

Daniel Vladco · Answer 1 · Sat May 23 2020 23:13:06 GMT+0800 (China Standard Time)

Hi @BenSlabbert , this is a great Idea. At the moment of writing this lib there wasn't such a functionality. Of corse you can open a PR.

Actually I thought about this at some point and I think Upload type would map perfectly as protobuf bytes

Daniel Vladco · Answer 2 · Sat Apr 17 2021 19:45:03 GMT+0800 (China Standard Time)

Hi @BenSlabbert , @toctan thank you for your contribution, I am planning to add this feature, however since @toctan 's last PR I did a big refactor to clean up the codebase so if you are willing resolve the conflicts that will be great.

Also I am wondering if just adding case graphql.Upload: to Bytes type will be enough to allow this functionality...
I have a feeling that we need to introduce a new scalar of type Upload but I am not very familiar with how gqlgen handles Upload files