Giters

danielsaidi / Sheeeeeeeeet

Sheeeeeeeeet is a Swift library for creating menus, custom action sheets, context menus etc.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make CollectionItem non-generic

danielsaidi opened this issue · comments

commented

That CollectionItem is generic makes it hard to decouple MenuItem from ActionSheetItemCell, since you can't type cast (e.g. if let item as? CollectionItem doesn't work with generic types) and can't use overridable @objc extensions. Imo, it also makes it harder to understand the class.

I will investigate if this item type could be made non-generic instead.

commented

I have managed to make this item type non-generic. It can be tested in the 3.0.0-beta branch.