Giters

danielrhodes / Swift-ActionCableClient

ActionCable is a new WebSocket server being released with Rails 5 which makes it easy to add real-time features to your app. This Swift client makes it dead-simple to connect with that server, abstracting away everything except what you need to get going.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename identifier to data or params

allaire opened this issue · comments

commented

Hi @danielrhodes,

I think it would be clearer to rename identifier to params or perhaps data in the create method (create(channel, identifier:, autoSubscribe:, bufferActions:). I see that the underlying API send identifier to the backend, but since name is a standalone parameter, I think it would make sense to abstract it a little bit more.

commented

I can tackle this if you want, I suppose I should create a new method and add a deprecation warning on the other? Let me know!