generalize MavenReleasePluginMessageFilter to support custom prefix
ittaiz opened this issue · comments
Hi,
I have a homebrew mechanism similar to the maven release plugin which adds its own commits.
I'd like to change the extract a filter from the MavenReleasePluginMessageFilter which accepts a prefix (the current filter will call that one with "[maven-release-plugin]") and so one can define a prefix which it wants to filter.
Hi, that sounds useful. As long as by default it filters out maven release commits, then it would be great to have this.
looking at the GenerateMojo class it seems that it currently just uses a closed list of filters.
I can do the above change pretty easily if i just expose a config value with a default value for the release plugin but i think the better approach should be to check if the custom filter prefix is configured and if so register an additional filter.
What do you think?
Of course in the generate mojo the Generator will be constructed with the default list (including the current maven release plugin filter) and optionally the new filter
Yes, your idea of adding a filter if there is a custom prefix sounds good. Thanks.