Giters

danieleteti / delphimvcframework

DMVCFramework (for short) is a popular and powerful framework for WEB API in Delphi. Supports RESTful and JSON-RPC WEB APIs development.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

firebird sql generators error

drcrck opened this issue · comments

commented

Hi Daniele,
there a bug in firebird sql construct if there are fields with spaces.
it's all ok for select, but update or insert crash.
in MVCFramework.SQLGenerators.Firebird should be modified CreateInsertSQL and CreateUpdateSQL
adding call to "GetFieldNameForSQL" and "GetParamNameForSQL" during sql creation.

row 107: lSB.Append(GetFieldNameForSQL(lKeyValue.Value.FieldName) + ',');
row 121: lSB.Append(':' + GetParamNameForSQL(lKeyValue.Value.FieldName) + ',');

and

row 186 : Result := Result + GetFieldNameForSQL(lKeyValue.Value.FieldName) + ' = :' + GetParamNameForSQL(lKeyValue.Value.FieldName) + ',';

ciao :)

commented

Hi. Currently fields with staces are not supported in FirebirdSQL, so this is the expected behaviour.
We'll consider your suggestions to implement the support.

Thank you

Ciao :-)

commented

The fix is in the repo. Please, test it and let me know.