Misleading comment in `state_machine`?
xobs opened this issue · comments
In the documentation for incoming_data()
in the state::Running
state, the comment is annotated as such:
gdbstub/src/stub/state_machine.rs
Lines 274 to 302 in d22eea8
However, contrary to the comment, it seems as though this performs state transitions as normal, and it doesn't always return a state that's state::Running
.
Is this comment incorrect? Does it need to be updated?
Yep, that's definitely wrong!
I believe I left that in from an earlier iteration of the code, and forgot to remove it.
Thanks for brining it to my attention. No need to send a PR or anything - I'll push up a commit fixing this shortly.
closed via d69da3a