Remove DateInput default hint 'For example, 12 11 2007'

Question

Remove DateInput default hint 'For example, 12 11 2007'

happy-devs opened this issue 2 years ago · comments

Hi @daniel-ac-martin, I'm using this library on a project and really appreciate the scope of its components; just noticed that the DateInput component includes a hint as a default and thought it should be flagged for removal in case some others are caught out.

Thanks again for the work on this!

Daniel A.C. Martin · Answer 1 · Mon Nov 21 2022 00:39:51 GMT+0800 (China Standard Time)

Hi @happy-devs.
Just to be clear, are you saying that you are seeing a hint even when you don't provide one to the component?

Daniel A.C. Martin · Answer 2 · Mon Nov 21 2022 00:40:44 GMT+0800 (China Standard Time)

Oh, sorry just spotted it.
Yes, that's a bug. Not sure how I managed that.

Thanks for raising it!

Daniel A.C. Martin · Answer 3 · Thu Nov 24 2022 22:38:48 GMT+0800 (China Standard Time)

Hi @happy-devs.

I've been thinking about this one. I think that I put in that default hint because all of the GDS examples have hints and the DateInput probably needs a hint in order to make it clear to users, how they should use it. e.g. That they should enter a number for the month rather than say 'Jan'.

Can you tell me any more about your use case where you don't want a hint?

Also, can you get rid of the hint by passing an empty string (hint="")?

Andrew Maguire · Answer 4 · Thu Nov 24 2022 23:24:09 GMT+0800 (China Standard Time)

Hi @daniel-ac-martin, sure can; this is more of personal opinion on my end to prevent any wrong hints getting through. thanks for clarifying!