Epileptic bug on MacOS
ronangaillard opened this issue · comments
I was seeing a similar issue in Linux/X11 with an intel card.
I changed the hi-dpi value in settings.json to false, and was able to avoid the issue.
"hiDPI": false,
Also got this issue on Mac OS.
"hiDPI": false
makes the window a little larger but still a small portion of the total window size.
At least on MacOS it seems that when using hiDPI the scale is reversed. I.e. in https://github.com/danfragoso/thdwb/blob/master/mustard/window.go#L35:
window := &Window{ title: title, width: int(float32(width) / xscale), height: int(float32(height) / yscale), hiDPI: hiDPI,
it should really be:
width: int(float32(width) * xscale), height: int(float32(height) * yscale),
That makes the window content fill the window (but then it goes back to small with flicker on resize, so I think the same needs to be done wherever the window resize code is).
I got this issue on Mac OS, too.
@raff That seems plausible for the scale issue. The resize callback is here: https://github.com/danfragoso/thdwb/blob/master/mustard/window.go#L139
I pushed the fix to my branch if anyone cares to try it? https://github.com/ajzaff/thdwb/tree/feature-content-scale-23
FWIW hiDPI
did not work well on my chromebook even with my fix.
Hi, sorry for the delay, I've been really busy with work this couple of weeks. I fixed the scaling issue on linux with commit 088ec74, can you guys try it again?
@ronangaillard @dyaskur @montyanderson @raff @bigwhite @ajzaff
@dyaskur, if you applied https://github.com/ajzaff/thdwb/tree/feature-content-scale-23, make sure you have hiDPI=true in settings.json.
The fix is still not perfect (on resizes there are cases depending on the window size where the screen goes white) but mostly works.