danalloway / react-country-flag

React component for emoji/svg country flags.

Home Page:https://danalloway.github.io/react-country-flag/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Country flags missing for Kosovo (XK) and Netherland Antilles (AN)

joshlbaker opened this issue · comments

  • Flags show up blank for these two countries
  • I believe Netherland Antilles is just The Netherlands so I can always just map one to the other, just wanted to bring it to your attention.
  • Using latest v1.0.1

ACK.
I'll take look into this as soon as I'm able.
Thanks for reporting this.

Amazing, thank you!

@joshlbaker haven't forgotten about this, will have something in during the holiday break most likely

@danalloway the CDN you were using to import the flag svgs has been updated with these flags so all you should need to do is update that to the latest 3.2.1

https://github.com/danalloway/react-country-flag/blob/master/src/index.js#L14
https://github.com/lipis/flag-icon-css

using latest CDN v3.2.1 as of our release 1.0.2

@LCCalado yea that is correct, can't do much about that
also, the ISO country code for Kosovo is XK not KV give that a try https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/xk.svg

Thanks. What about "Netherland Antilles" and "Canary Islands"?

I don't maintain the Flag library so I'm not sure why they are not included, there are no emoticons for them either.
I would recommend a custom solution for those edge case flags.

I don't maintain the Flag library so I'm not sure why they are not included, there are no emoticons for them either. I would recommend a custom solution for those edge case flags.

@danalloway Can you guide me on how to put custom flags? Thank you :)