damnhandy / Handy-URI-Templates

A Java URI Template processor implementing RFC6570

Home Page:https://damnhandy.github.io/Handy-URI-Templates/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

More Encoding problems with UriUtil

tekener opened this issue · comments

Hi Ryan,

we found some more "bugs" in the UriUtil class :(

The problem is, that the util class uses a blacklist to identify the chars to encode. The corresponding JDK class URLEncoder is using a whitelist. I think the whitelist is the better approach for this problem.

So, what do you think how should i fix it ;-)
a) introduce a white list to the UriUtil
b) replace the UriUtil with the URLEncoder, or in a first step, use the UriUtil as delegate for the Encoder
c) add more and more exotic chars to the black list :-(

Is there a reason, why you differ between "fragments" and others?

Thanx, Björn

Hi Ryan,
i fixed it using a whitelist. See my pull request for details.

thx, Björn

I like it.