Expanding enums

Question

Expanding enums

vicmosin opened this issue 9 years ago · comments

Why forbid to pass enums??

https://github.com/damnhandy/Handy-URI-Templates/blob/master/src/main/java/com/damnhandy/uri/template/DefaultVarExploder.java#L120

Ryan J. McDonough · Answer 1 · Fri Nov 06 2015 22:30:55 GMT+0800 (China Standard Time)

Enums wouldn't be captured there, but here:

https://github.com/damnhandy/Handy-URI-Templates/blob/master/src/main/java/com/damnhandy/uri/template/UriTemplate.java#L609

The DefaultVarExploder should only be called when the type is not a primitive, CharSequence, Number, or Date type. I haven't tested enums, but there probably needs to be some thought into how they are handled.

Victor Mosin · Answer 2 · Fri Nov 06 2015 22:32:49 GMT+0800 (China Standard Time)

So they are not)) it fails with The value must an object exception

Ryan J. McDonough · Answer 3 · Sat Nov 07 2015 08:46:49 GMT+0800 (China Standard Time)

Clearly not tested :) I'll have a gander at this over the weekend.

Ryan J. McDonough · Answer 4 · Sat Nov 07 2015 22:09:58 GMT+0800 (China Standard Time)

@vicmosin I'm really surprised that such an obvious bug took 4 years for someone to find it. Thanks for the report. A few minor tweaks and it's functional now. I've pushed a snapshot to Maven Central under version 2.1.0-SNAPSHOT Should have a release out by the end of the weekend.

Victor Mosin · Answer 5 · Sun Nov 08 2015 16:27:58 GMT+0800 (China Standard Time)

Confirmed, 2.1.0-SNAPSHOT fixes the issue.
What about 2.0.5-SNAPSHOT described in docs?

Ryan J. McDonough · Answer 6 · Mon Nov 09 2015 00:23:49 GMT+0800 (China Standard Time)

I'm going straight to 2.1. Should be posting that later today.