Add OSGi manifest headers
mattbishop opened this issue · comments
One cannot use handy-uri-templates in an OSGi environment like Eclipse, Felix, Sling, etc. because the jar file is missing the requisite OSGi headers. These are usually generated at build time by the maven-bundle-plugin found here:
http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html
This sounds reasonable. I'll add this to 2.0, which should be available in a few days.
@mattbishop This is now in the latest snapshot build in version 2.0.0-SNAPSHOT. I'm not a big OSGi user, so I'm not quite sure how to validate it. If you could give it a whirl and let me know if it's working that'd be appreciated.
Well this looks like serious overkill! Where did you find this code?
I think you need about three lines of plugin configuration to get what we need.
On 2013-07-11, at 6:27 PM, "Ryan J. McDonough" notifications@github.com wrote:
@mattbishop This is now in the latest snapshot build in version 2.0.0-SNAPSHOT. I'm not a big OSGi user, so I'm not quite sure how to validate it. If you could give it a whirl and let me know if it's working that'd be appreciated.
—
Reply to this email directly or view it on GitHub.
LOL! As you might have guessed, I'm not terribly familiar with OSGi packaging ;) I can't recall the location I got that info from. Been re-reading some OSGi info and and made some more changes. I pulled out most of what was there and kept it to the basics that the bundle plugin generates. The latest snapshot now has these changes.
It looks much better now! You could probably get rid of the entire block but I don't know what does. The others are the default values for the plugin.
Thanks @mattbishop, I'll close this out then.