Keyframe selection change the order of elements
ebarranco opened this issue · comments
Vpaint - Master
OS - Linux
Issue:
Using Keyframe selection (k) changes the order of drawings when you are working with more of two elements.
Steps:
- Draw three circles of different size or color and stack them in particular order
- Select the drawings and Motion Copy/Paste
- Add a in-between with keyframe selection
- The order of the drawings has changed.
Good catch! I definitely forgot to think about depth ordering when keyframing. This should be interesting to fix, and the solution will be directly useful for VGC too, so I'll clearly spend the time to fix for VPaint 1.7.
More minimal/detailed example:
- Draw an edge E1
- Draw an overlapping edge E2 on top (e.g., with auto-intersections disabled)
- Select E1 and stack it above E2 with PageUp
- Select All and copy-motion-paste to another frame
- Add an inbetween frame
Great! Originally found the problem just with edges but took me a long time to figure it out what was happening so I thought the use of faces and colors was more clear to report the issue.
Absolutely, using colors or faces definitely help to "see" the depth-ordering problem :)
Alright, it turns out I did not completely forgot to think about depth ordering when keyframing, but got it wrong. It should be fixed now, and was actually easier to fix than I thought :)
Let me know if it seems to work for you, and by the way, also let me know if you see any performance regressions since my fix for #105.
I'm glad to read that, it works pretty well! I don't notice any change in performance, I'll continue testing and let you know if behaves otherwise.
Great, thanks! :)