dagger / dagger

An engine to run your pipelines in containers

Home Page:https://dagger.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't load local module at absolute path

shykes opened this issue · comments

Problem

When loading a local module, absolute paths are not supported.

Example:

dagger -m /foo/bar functions

Output:

  ! local module source root path is absolute: /foo/bar

Solution

Allow loading local modules from a local path.

@sipsma, is there any security / behavior concerns around allowing absolute paths ?
It seems that the restriction allows for just related path inside a module's context to be run. I am currently checking #7476, where the tests seem to pass (after a rebase), just wanted to double check 🙏

@sipsma, is there any security / behavior concerns around allowing absolute paths ? It seems that the restriction allows for just related path inside a module's context to be run. I am currently checking #7476, where the tests seem to pass (after a rebase), just wanted to double check 🙏

Got back here #7476 (comment)