dagger / dagger-for-github

GitHub Action for Dagger

Home Page:https://github.com/marketplace/actions/dagger-for-github

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

🧪 Handle `version` inputs that start with `v`

jpadams opened this issue · comments

curl -sL https://dl.dagger.io/dagger/install.sh 2>/dev/null | \
        DAGGER_VERSION='v0.9.2' sh
sh debug downloading files into /var/folders/s4/xyj9q5ps2ys3rc9nsps1v20m0000gn/T/tmp.tTShNB7AUU
sh debug http_download https://dl.dagger.io/dagger/releases/v0.9.2/dagger_vv0.9.2_darwin_arm64.tar.gz
sh debug http_download_curl received HTTP status 403

errors out because of extra v. Could be solved be removing the v here or could also be fixed upstream in the installer script, which might be better.

I have raised an MR to fix this in the install.sh script, dagger/dagger#7010

@jpadams just to let you know, my fix to the install script has been merged in. So, in theory, this ticket could be closed?

yup, we should do a release to get this fix into the hands of users - I had the same issue :)