ci: docker build workflow upgrade
hero-intelligent opened this issue · comments
Basically done. Please review my code first. Now there is a big commented block which keepsalmost all the working process. repo: hero-intelligent/daed
Details tomorrow.
Thanks for opening this issue!
@hero-intelligent cc @kuni_sh
If you are satisfied so far, I will open a pr, and modify again.
Please don't worry about those failures in my actions, nor the big chunk of commented code. As I have no redhat account, i have to comment out this part. My dockerhub username is different from that of github, so, our code cannot be the same.
Now my code should work in this repo. But we need cooperation this time.
The docker build process takes about 48 minutes, which is very long, so I have to treasure each test.
Full change log tomorrow.
@yqlbu @kunish These will be the final change log when opening pull request
Change Log
ci(docker): docker build once and push to multiple repos
ci(docker): docker build and push with tags
ci(docker): come back arm64 platform support (Experimental)
ci(docker): publish dockerhub image
ci(docker): action version upgrade
ci(docker): multiple action trigger
ci(docker): build with tag on dashboard
Others
A dockerhub account that has write access to daeuniverse/daed is needed! @mzz2017
Now the release and prerelease trigger has working perfectly, and building process works just fine.
Since my dockerhub username is different from github, I need to modify my code a little bit so that I can test if it can successfully push to both ghcr and dockerhub WITH TAGS.
dockerhub repo: huangqizigailee/daed
You can test if this image works just fine so far.
See you 48 minutes later.
LGTM. I can provide the access to dockerhub account daeuniverse.
the result looks something like this: https://hub.docker.com/r/huangqizigailee/daed-test
I'll open a pull request after the secrets ${{ github.DOCKERHUB_USERNAME }} and ${{ github.DOCKERHUB_PASS }} are ready. @mzz2017 please reply when ready. Apologies that I didn't follow your commit naming guidelines this time. As for testing on pushing, we need to cooperate.
@hero-intelligent You mean that I should give the secret name "github.DOCKERHUB_USERNAME" instead of "DOCKERHUB_USERNAME"?
@hero-intelligent BTW, can you use Access Tokens in docker hub?
https://github.com/daeuniverse/dae/blob/main/.github/workflows/docker.yml#L48
Looks yes.
I've added above two secrets.