daattali / ggExtra

📊 Add marginal histograms to ggplot2, and more ggplot2 enhancements

Home Page:http://daattali.com/shiny/ggExtra-ggMarginal-demo/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

R CMD check results in NOTE

crew102 opened this issue · comments

geom_histogram2: no visible binding for global variable ‘..density..’

This should help get rid of this note-

# defining global variables and functions to appease R CMD Check

utils::globalVariables(names = c(".",
                                 "..density..",),
                       package = "ggExtra",
                       add = FALSE)

You can literally copy this code into a new global_vars.R file in the R folder and that's that!
(e.g. https://github.com/IndrajeetPatil/ggstatsplot/blob/master/R/global_vars.R)

I have never forked a repo, so a bit wary of doing that.

@IndrajeetPatil we can do that it's not a problem. But because it is such a trivial change, it would be a great first experience at learning how the open collaboration works on github. Are you sure you don't want to look into making the PR yourself? Thanks for the tip regradless

I should add: you can't do any damage. You can try and learn from the process, but no damage will be done

Thanks for the encouragement :)

Created a PR; let's see if this works.

Fixed