da2x / instapaper-webextension

Web extension that adds a button with Read Now and Read Later with Instapaper options to Firefox’s toolbar.

Home Page:https://www.daniel.priv.no/web-extensions/instapaper.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Release 1.2.0 doesn't ship with styles folder

Jackymancs4 opened this issue · comments

Hello @da2x
The current release package does not contain the styles folder and the addon is not styled at all .
I've noticed it a while ago but never found time to investigate.

How the heck can I possibly have missed that!? 🤯I use this several times a day.

Thanks for the report. I’ll push out a new version right away.

Hey, thanks for the quick new release.
Unluckily, release 1.2.1 also lack of the styles folder, making this still an issue. You can quickly see that here.

If you have always used the newly added makefile, the problem might be

SOURCES += $(shell find styles -name '*.cs')

being

SOURCES += $(shell find styles  -name '*.cs')

instead of

SOURCES += $(shell find styles  -name '*.css')

Not sure though, as I haven't tested it.

Fixed in commit 9326892. The build script should prevent this from happening again. Thanks again for checking my work!