INPUTBOX close effect
mjkrg opened this issue · comments
mjkrg commented
I was expecting that when the INPUTBOX dialog was closed, the $(INPUT)
variable would be an empty string but it rather contains the previously OK'd string. If this behavior is preferred, then there should be a way to detect whether the user action was OK or CANCEL in order for the executing script to know how to proceed.
Vitaliy Dovgan commented
Fixed in 'develop':
542e786
Will be included in the next release of NppExec.
mjkrg commented
Cool. While we're at it, could we have the Escape key close the dialog box as is standard rather than using the mouse?
…----- Original Message -----
Date: Mon, Jun 14, 2021 at 7:29 AM
From: Vitaliy Dovgan ***@***.***>
To: d0vgan/nppexec ***@***.***>
Cc: mjkrg ***@***.***>, Author ***@***.***>
Subject: Re: [d0vgan/nppexec] INPUTBOX close effect (#41)
Fixed in 'develop':
542e786
Will be included in the next release of NppExec.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#41 (comment)
Vitaliy Dovgan commented
Just wondering: what is the purpose of calling inputbox
without providing any input value?
mjkrg commented
Mostly human error. Imagine a case where you have an NppExec script that does something with your input (e.g. uses it as email subject/recipient, commit message, Twitter post, etc.) However, after triggering it, you realize you need to make some changes before proceeding with the action, which means you want the process stopped. That's where you may want to close the dialog without providing a value. Currently, submitting a blank input works like the commit you just pushed but I often found myself closing the dialog box rather than submitting an empty input.
…----- Original Message -----
Date: Mon, Jun 14, 2021 at 10:19 AM
From: Vitaliy Dovgan ***@***.***>
To: d0vgan/nppexec ***@***.***>
Cc: mjkrg ***@***.***>, Author ***@***.***>
Subject: Re: [d0vgan/nppexec] INPUTBOX close effect (#41)
Just wondering: what is the purpose of calling `inputbox` without providing any input value?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#41 (comment)
Vitaliy Dovgan commented
mjkrg commented
Nice. Thanks bud.
…----- Original Message -----
Date: Mon, Jun 14, 2021 at 3:59 PM
From: Vitaliy Dovgan ***@***.***>
To: d0vgan/nppexec ***@***.***>
Subject: Re: [d0vgan/nppexec] INPUTBOX close effect (#41)
91d317f
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#41 (comment)
Vitaliy Dovgan commented