Giters

czukowski / I18n_Plural

I18n module for grammatically correct plural inflections, and maybe even some extra features related to i18n.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Error in documentation

ValerchikV opened this issue · comments

commented

In documentation for KO3.3
README.md:277
class Validation extends I18n_Validation {} must be class Validation extends I18n\Validation {}

README.md:333
class Validate extends I18n_Validation {} must be class Validation extends I18n\Validation {}

README.md lines 217 219 223 329 424 I18n_Date -> I18n\Date

commented

I see you start using namespaces from ver for KO3.3 but this is not usual way for kohana you sure this needed ? It not respect Kohana coding conventions

commented

Thanks for the notice, I'll fix the readme.

To the namespaces: although, as many have noticed and discussed, they're far from ideal in PHP in general, they really help me to organize classes and make the class names look a little bit cleaner. I can't see any serious reason to avoid the namespaces since Kohana's started to support them.