cypress-io / netlify-plugin-cypress

Versions

What is this plugin's version? latest
What is Cypress version? latest
What Netlify build image are you using? Ubuntu Xenial 16.04
What is the Node version if you know it? 12
What is the NPM version if you know it? 6

Describe the bug
When running a netlify build, the plugin serves the built assets itself to run tests, rather than setting baseUrl to the deployed netlify domain:

netlify-plugin-cypress/src/index.js

Lines 137 to 157 in c963ad0

    
           async function postBuild({ fullPublishFolder, record, spec, group, tag, buildUtils }) { 
        
             const port = 8080 
        
             const server = serveFolder(fullPublishFolder, port) 
        
             debug('local server listening on port %d', port) 
        
             const baseUrl = `http://localhost:${port}` 
        
             const results = await runCypressTests(baseUrl, record, spec, group, tag) 
        
             await new Promise((resolve, reject) => { 
        
               server.close(err => { 
        
                 if (err) { 
        
                   return reject(err) 
        
                 } 
        
                 debug('closed local server on port %d', port) 
        
                 resolve() 
        
               }) 
        
             }) 
        
             processCypressResults(results, buildUtils) 
        
           }

It should run tests against the live version because simply serving the built assets is missing any redirects, etc that are relevant to the application and set up in either netlify.toml or the netlify UI.

The relevant URLs are accessible via environment variables: https://docs.netlify.com/configure-builds/environment-variables/#deploy-urls-and-metadata

Blocked until Netlify plugins receive onDeploy hook from the outside system

Finally there is onSuccess event https://community.netlify.com/t/netlify-build-plugins-changes-to-when-onsuccess-and-onend-are-invoked-during-the-build-cycle/23489

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

	async function postBuild({ fullPublishFolder, record, spec, group, tag, buildUtils }) {
	const port = 8080
	const server = serveFolder(fullPublishFolder, port)
	debug('local server listening on port %d', port)

	const baseUrl = `http://localhost:${port}`

	const results = await runCypressTests(baseUrl, record, spec, group, tag)

	await new Promise((resolve, reject) => {
	server.close(err => {
	if (err) {
	return reject(err)
	}
	debug('closed local server on port %d', port)
	resolve()
	})
	})

	processCypressResults(results, buildUtils)
	}

Plugin should use the deployed netlify subdomain to run tests, not localhost