Add `unsafe-to-chain-command` exception for `type` and `clear` commands when used together

Question

Add `unsafe-to-chain-command` exception for `type` and `clear` commands when used together

fuxingloh opened this issue 2 years ago · comments

According to the Cypress documentation on clear, it is considered a correct usage to chain the clear command with the type command, and vice versa:

cy.get('input[name="name"]').clear().type('Jane Lane')
cy.get('input[name="name"]').type('Jane Lane').clear()

As of v2.13.2, the current lint rule does not allow this usage.

Ben M · Answer 1 · Mon Apr 10 2023 20:55:19 GMT+0800 (China Standard Time)

@fuxingloh , Thank you for submitting your feature request. Cypress Product Managers will review this request and consider it for future implementation. Please remember we cannot guarantee this will be implemented in a specific timeframe or at all. Please see the Cypress App Product Roadmap for what we currently have in the works.

Vik · Answer 2 · Mon Apr 17 2023 12:48:36 GMT+0800 (China Standard Time)

yes. I just had to ingore this eslint rule. I have too many cases

  cy.getBySel('post.title').find('input').clear().type(newPost.title)

dqiubread · Answer 3 · Tue Sep 19 2023 06:08:48 GMT+0800 (China Standard Time)

Any update on this change?

Cory Deppen · Answer 4 · Sat Apr 06 2024 04:19:00 GMT+0800 (China Standard Time)

It's been a year since this was reported. Can a maintainer at least confirm that this is something that needs to be addressed in the plugin or if the docs aren't completely accurate and the plugin is reporting correctly?

oracast · Answer 5 · Sat Apr 06 2024 04:20:59 GMT+0800 (China Standard Time)

it is dead. just move to playwright

dqiubread · Answer 6 · Sat Apr 06 2024 04:32:52 GMT+0800 (China Standard Time)

It's been a year since this was reported. Can a maintainer at least confirm that this is something that needs to be addressed in the plugin or if the docs aren't completely accurate and the plugin is reporting correctly?

This PR should fix it but it hasnt been merged. https://github.com/cypress-io/eslint-plugin-cypress/pull/141/files
In the meantime my team decided to use patch-package with the changes in the PR to fix it.

dqiubread · Answer 7 · Sat Apr 06 2024 04:34:40 GMT+0800 (China Standard Time)

It's been a year since this was reported. Can a maintainer at least confirm that this is something that needs to be addressed in the plugin or if the docs aren't completely accurate and the plugin is reporting correctly?

This PR should fix it but it hasnt been merged. https://github.com/cypress-io/eslint-plugin-cypress/pull/141/files In the meantime my team decided to use patch-package with the changes in the PR to fix it.

Sorry just realized this is on type and clear command chaining and not the chaining custom commands to other commands. My team decided to just un chain them.