cypress-io / cypress-example-kitchensink

Current

The CircleCI workflow runs

linux-build tests in the now unsupported Node.js 16 version v16.16.0 and runs
mac-build under v18.16.0.

Compare to:

Valid Node.js versions defined in

cypress-example-kitchensink/package.json

Lines 78 to 79 in 277e055

"engines": {

"node": "^18.0.0 || >=20.0.0"

and
default Node.js 20 in .node-version

Note:

win-build runs under v20.5.1

needs no change.

Desired

The CircleCI workflow should be modified so that Node.js 20 is used for testing for both linux-build and mac-build

Test code

Submit a PR on https://github.com/cypress-io/cypress-example-kitchensink/pulls

Cypress version

13.2.0

Operating system

Linux
macOS

Logs

See https://app.circleci.com/pipelines/github/cypress-io/cypress-example-kitchensink

-> linux-build
-> 3 machines
-> Installing NPM packages

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'cypress-example-kitchensink@0.0.0-development',
npm WARN EBADENGINE   required: { node: '^18.0.0 || >=20.0.0' },
npm WARN EBADENGINE   current: { node: 'v16.16.0', npm: '8.11.0' }
npm WARN EBADENGINE }

-> mac-build
-> mac-test
-> Run Cypress

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        13.2.0                                                                         │
  │ Browser:        Electron 114 (headless)                                                        │
  │ Node Version:   v18.16.0 (/Users/distiller/.nvm/versions/node/v18.16.0/bin/node)               │
  │ Specs:          20 found (1-getting-started/todo.cy.js, 2-advanced-examples/actions.cy.js, 2-a │
  │                 dvanced-examples/aliasing.cy.js, 2-advanced-examples/assertions.cy.js, 2-advan │
  │                 ced-examples/connectors.cy.js, 2-advanced-examples/cookies.cy.js, 2-advanced-e │
  │                 xamples/cypress_api.cy....)                                                    │
  │ Searched:       cypress/e2e/**/*.cy.{js,jsx,ts,tsx}                                            │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

Closing, as linux-build now runs under Node.js v18.16.1.

This is still inconsistent, but it is good enough.

	"engines": {
	"node": "^18.0.0 \|\| >=20.0.0"