Fix the gitlab ci
jg-cantaa opened this issue · comments
The Gitlab CI is failing for the kitchensink.
Logs for the failure can be seen here:
https://gitlab.com/cypress-io/cypress-example-kitchensink/-/jobs/3220209059
In a private repo, forked off the kitchensink, the CI fails with the same error.
Looks like the wrong version of Node - we will need to update to Node 14.
Looks like the wrong version of Node - we will need to update to Node 14.
I wonder why you suggest Node.js 14 rather than the LTS version Node.js 18.
The last commit on https://gitlab.com/cypress-io/cypress-example-kitchensink/-/commits/master is from Dec 7, 2022, so the repo is out of date in any case and not synced with this repo. Is that supposed to happen automatically or is it somebody's responsibility to sync it manually from time to time?
I think I wrote Node.js 14 since that's when that syntax was first supported. We can definitely update to Node.js 18, though. I don't think there's a specific person or team responsible for this particular task or repo.
- I have submitted #614 to update several examples, including the GitLab example.
- It's good that you pointed out the error in .gitlab-ci.yml. I was able to get that corrected in PR #614.
- The Cypress.io team however decided that they will not continue to keep this workflow running live and the repository https://gitlab.com/cypress-io/cypress-example-kitchensink/ is planned to be archived (see #615).
- I have also submitted PR #625 to remove the GitLab CI status badge from the README file CI Status table.
So I suggest to close this issue: either now, or after the remaining PRs mentioned above have been merged.
@lmiller1990 No we can close.