Do not change process.cwd()
brian-mann opened this issue · comments
Brian Mann commented
Just pass it as an option to execa
.
Line 30 in 7bac92d
Also FWIW the .tap(...)
call to change back process.cwd
will not be called if the promise throws, resulting in a mutated process.cwd
Gleb Bahmutov commented
Yeah that good observation! And this is more robust too. Will fix this
…Sent from my iPhone
On Oct 29, 2017, at 20:06, Brian Mann ***@***.***> wrote:
Just pass it as an option to execa.
https://github.com/cypress-io/commit-info/blob/7bac92d6dab2d4ace9d53207204fa8ef8e0e18b8/src/git-api.js#L30
Also FWIW the .tap(...) call to change back process.cwd will not be called if the promise throws, resulting in a mutated process.cwd
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Gleb Bahmutov commented
Version 1.2.2
has been published to NPM. The full release note can be found at commit-info/releases/tag/v1.2.2.
Tip: safely upgrade dependency @cypress/commit-info in your project using next-update