Giters

cybercog / laravel-love

Add Social Reactions to Laravel Eloquent Models. It lets people express how they feel about the content. Fully customizable Weighted Reaction System & Reaction Type System with Like, Dislike and any other custom emotion types. Do you react?

Home Page:https://komarev.com/sources/laravel-love

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[9.x] Remove dependencies from console commands constructors

antonkomarev opened this issue · comments

commented

It will be better to remove dependencies from constructor methods of the console commands because Laravel loading those dependencies not on command usage but on command registering.

For example in class Cog\Laravel\Love\Console\Commands\SetupReactable there are dependencies in constructor:

public function __construct(Filesystem $files, MigrationCreator $creator, Composer $composer)
{
    parent::__construct();

    $this->files = $files;
    $this->creator = $creator;
    $this->composer = $composer;
}
commented