cyberark / conjur-service-broker

Implementation of the Open Service Broker API for Conjur

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Health check provides more meaningful error message

jtuttle opened this issue · comments

In the bin/health_check.rb script we raise an error with a useful message and then rescue it and throw it away. We should make sure we are providing a useful error wherever possible.

^^ This was a huge source of time waste for us in working with CyberArk to get the service broker working. Ended up being that the certificate on our host was not valid for the FQDN and thus it failed to validate the cert. Error checking is needed so that this can more easily be resolved, it just said "Error: There is an issue with your Conjur configuration. Please verify"
" that the credentials are correct and try again" and that is not as helpful as it could be 👍

We recently did another deploy of this and again the error message caused us great headaches. It should check whether an ASG is causing an issue. By default our ASGs were causing the app to break. the error implied we had configured something wrong in conjur but in fact it was simply unable to connect to conjur.