Enforce Rebase GH Action gives false success results

[John O'Donnell]

Summary

Currently, the GH Action Enforce Rebase will report correctly when a PR is first opened. However, if
commits are merged to main, and then more changes are made to the PR without rebasing, the Action will continue to
report a successful rebase check.

Steps to Reproduce

This bug is reproducible in the normal dev cycle.

Steps to reproduce the behavior:

1. Open a test PR, which is correctly rebased on main. The Enforce Rebase action will succeed.
2. Merge new commits into main.
3. Without rebasing, add more commits to the test PR. The Enforce Rebase action will still succeed, even though the branch it is based on is a number of commits behind main.

Expected Results

The GitHub Action should fail, and report that the PR needs to be rebased on main.

Actual Results (including error logs, if applicable)

The GitHub Action succeeds.

Reproducible

• Always
• Sometimes
• Non-Reproducible

Version/Tag number

n/a

Environment setup

n/a

Additional Information

n/a

[Ellis Wright]

@john-odonnell Is there a specific PR you had this issue with? I just tried to produce the same result with the authenticators endpoint and couldn't get it not to fail.

[John O'Donnell]

@telday ya know, I'm having trouble reproducing myself. I remember making the issue regarding the whoami PR, but I guess I might have misinterpreted the order or operations. The commits might have been merged after the run had already succeeded.

Even if this is the case, I would also consider that a false positive. I guess we can table the issue for now to refine it.

[Ellis Wright]

@john-odonnell Okay, I am going to close this issue for now, but we should keep our eyes out for any issues with it. We may have to re-open at some point.