cx20 / gltf-test

Testing the glTF Loader and WebGL Library

Home Page:https://cx20.github.io/gltf-test/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PlayCanvas viewer needs to be updated to new animation component

willeastcott opened this issue · comments

Currently, the viewer in this repo is failing the InterpolationTest test. This is because it is based on the animation component. It needs to be updated to the anim component, which is now used by the official PlayCanvas viewer:

playcanvas/model-viewer#17

Then, InterpolationTest will pass successfully.

commented

@willeastcott Thanks to your advice, I've confirmed that the Animation in InterpolationTest works.
However, the animation doesn't seem to start unless I click on it. Perhaps I'm having a usage problem, but I haven't been able to investigate it. Can you give me additional advice?

PlayCanvas v1.33.0-dev + InterpolationTest.gltf result:
image

Thanks for trying to fix this so quickly! @slimbuck can provide you some advice tomorrow (since he was the one who fixed this in our viewer today). We're hoping we can flip all tests to pass (except for extension tests) by tomorrow. 😄

Hi @cx20,

The PC viewer goes to some trouble to only render frames when necessary so you can leave the viewer tab open without it killing your GPU/battery. :)

Just set autoRender to true at https://github.com/cx20/gltf-test/blob/master/examples/playcanvas/index.js#L126

Thanks!

I went ahead and submitted a PR #129

commented

I confirmed that the PR I received solved the problem.

PlayCanvas v1.32.3 + InterpolationTest.gltf result: