Sourcelink tool issues with FsToolkit.ErrorHandling package

Question

Sourcelink tool issues with FsToolkit.ErrorHandling package

TheAngryByrd opened this issue 5 years ago · comments

FsToolkit.ErrorHandling just published with support for SourceLink using Microsoft.SourceLink.GitHub. I'm using the global sourcelink tool to do some testing of the package, which I'm assuming should work.

When I download the package from nuget and run sourcelink test I get an error

sourcelink test fstoolkit.errorhandling.1.1.0.nupkg
Device not configured

When I run it against the package built locally it seems fine

sourcelink test FsToolkit.ErrorHandling.1.1.0.nupkg
sourcelink test passed: lib/net461/FsToolkit.ErrorHandling.pdb
sourcelink test passed: lib/netstandard2.0/FsToolkit.ErrorHandling.pdb

Also when I run any of the print commands on either the downloaded or the locally built I get an error

sourcelink print-urls FsToolkit.ErrorHandling.1.1.0.nupkg
Invalid COR20 header signature.

Do you have any guidance diagnosing this? Thanks!

Cameron Taggart · Answer 1 · Wed May 08 2019 16:21:40 GMT+0800 (China Standard Time)

I would download the nupkg from the server, unzip it, and run sourcelink test on each of the pdb files as a start.

Jimmy Byrd · Answer 2 · Wed May 08 2019 21:34:42 GMT+0800 (China Standard Time)

Still the same error

sourcelink test FsToolkit.ErrorHandling.pdb
Device not configured

Jimmy Byrd · Answer 3 · Wed May 08 2019 21:39:41 GMT+0800 (China Standard Time)

Running print-urls does return something

sourcelink print-urls FsToolkit.ErrorHandling.pdb
108c97e71af54a0fb3d40544095ae9a5 md5 fsharp /Users/tamizhvendan/DemystifyFpWorks/FsToolkit.ErrorHandling/src/FsToolkit.ErrorHandling/List.fs
https://demystifyfp/raw/demystifyfp/FsToolkit.ErrorHandling/68a1c34d29809b5c60cb53ee9e7d4591229fb54f/src/FsToolkit.ErrorHandling/List.fs
5de054cef9dc4df18b20eb43abcc6ab6 md5 fsharp /Users/tamizhvendan/DemystifyFpWorks/FsToolkit.ErrorHandling/src/FsToolkit.ErrorHandling/Option.fs
https://demystifyfp/raw/demystifyfp/FsToolkit.ErrorHandling/68a1c34d29809b5c60cb53ee9e7d4591229fb54f/src/FsToolkit.ErrorHandling/Option.fs
...

But the urls seems wrong. I'll probably have to open an issue in the dotnet/sourcelink repository too.

Cameron Taggart · Answer 4 · Wed May 08 2019 21:52:58 GMT+0800 (China Standard Time)

Can you print the sourcelink json?

Jimmy Byrd · Answer 5 · Wed May 08 2019 21:54:17 GMT+0800 (China Standard Time)

$ sourcelink print-json FsToolkit.ErrorHandling.pdb
{"documents":{"/Users/tamizhvendan/DemystifyFpWorks/FsToolkit.ErrorHandling/*":"https://demystifyfp/raw/demystifyfp/FsToolkit.ErrorHandling/68a1c34d29809b5c60cb53ee9e7d4591229fb54f/*"}}

I opened an issue over in FsToolkit's repo. I think we may be missing the PublishRepositoryUrl as a needed project property.

Cameron Taggart · Answer 6 · Wed May 08 2019 21:57:12 GMT+0800 (China Standard Time)

Yeah, that URL is wrong. Start there. It should be the full url.
https://github.com/dotnet/sourcelink#using-source-link-in-net-projects
~~Do you have <PublishRepositoryUrl>true</PublishRepositoryUrl>?~~

Jimmy Byrd · Answer 7 · Wed May 08 2019 21:58:49 GMT+0800 (China Standard Time)

Thanks for confirming my suspicion!

Cameron Taggart · Answer 8 · Thu May 23 2019 18:07:16 GMT+0800 (China Standard Time)

@TheAngryByrd, it looks like you may have solved this: https://github.com/demystifyfp/FsToolkit.ErrorHandling/pull/44/files

Jimmy Byrd · Answer 9 · Thu May 23 2019 21:30:55 GMT+0800 (China Standard Time)

Yep the main issue is fixed now.

I'm still curious as to why I get :

sourcelink print-urls FsToolkit.ErrorHandling.1.1.0.nupkg
Invalid COR20 header signature.

Want me to open a new issue for it?

Cameron Taggart · Answer 10 · Sat Jul 20 2019 02:25:03 GMT+0800 (China Standard Time)

@TheAngryByrd, can you please open up an issue for the COR20 header error? Did you resolve it?

Jimmy Byrd · Answer 11 · Wed Jul 24 2019 03:20:44 GMT+0800 (China Standard Time)

I didn't resolve it but I'll get to opening another issue sometime soon