ci: GitHub workflows fail to build container-images for multiple architectures

Question

ci: GitHub workflows fail to build container-images for multiple architectures

nixpanic opened this issue 3 years ago · comments

#89 changed how architectures are passed to the GitHub workflows. It seems that #91 was built only on one platform, instead of linux/amd64, linux/arm64 and linux/arm/v7.

For some reason the secrets.BUILD_PLATFORMS does not seem to be set for GitHub Actions?

Niels de Vos · Answer 1 · Wed Jan 19 2022 21:44:28 GMT+0800 (China Standard Time)

Maybe there is some GitHub access limitation:

You can use and read encrypted secrets in a workflow file if you have access to edit the file.

The user creating the PR, will not have access to edit the file directly. Creating a PR from a branch in the local repository (#90) did work. That branch might have "access to edit the file"?

Niels de Vos · Answer 2 · Wed Jan 19 2022 22:20:22 GMT+0800 (China Standard Time)

The behaviour is intentional and documented in a GitHub security guide:

Workflows triggered using the pull_request event have read-only permissions and have no access to secrets.

We'll need to think of an other way to limit building for multiple platforms.

Madhu Rajanna · Answer 3 · Wed Jan 19 2022 22:21:22 GMT+0800 (China Standard Time)

Yes due to security reason its done, sorry i forgot about it :( do we need to revert back to the PR introduced this one?

Niels de Vos · Answer 4 · Thu Jan 20 2022 18:15:16 GMT+0800 (China Standard Time)

Yes due to security reason its done, sorry i forgot about it :( do we need to revert back to the PR introduced this one?

Reverting is probably not needed. The builds after merging build all platforms, so that is fine for now.

I'd like some way of configuring it in a single place, so that it is easy to adjust in forks of this repo. Just not sure what/where that configuration should be done.