Three failing tests for whatthepatch.patch module
thoward opened this issue · comments
I found a small bug with the unified diff parsing, and was planning to submit a PR. In the process of doing that, I decided to run through the tests. However, I found that test_patch.py
, at current master, has three failing tests.
Should I ignore those and assume that if nothing new breaks, my PR won't be introducing breaking changes?
The failing tests are:
Thanks,
Troy
Yes, these tests have been broken for quite some time. They are examples of real diffs I've found that are not yet handled and are reminders for work yet done. I wouldn't worry about it :)
Fixed these!
Thanks to your intuition in fixing #2, which I used to fix the _blah tests (that I should rename...). 🎅