Unread emails are white in Row layout (v4)
laurens94 opened this issue · comments
I'm not sure if you already want issues for the v4 versions, but I'll post this anyway ;)
Everything looks perfect in Column layout (the email preview-pane), but in Row layout the unread emails seem to have a white background.
Keep up the good work! It's much appreciated 👍
Absolutely, thanks for reporting this @laurens94. Could you let me know which theme you are using? I cannot replicate this in any of them at the moment.
I assume it is the full version of a theme, if so could you give this a try and let me know if you still have the issue?
https://raw.githubusercontent.com/csalmeida/protonmail-themes/themes-v4/themes/green_lume/green_lume_full.css
All themes can be found here for v4.0.0:
https://github.com/csalmeida/protonmail-themes/tree/themes-v4/themes
I was using exactly that theme! ;)
It seems the following css (from the default Protonmail styling) is making it white:
.conversation:not(.read):not(.active) {
background: #fff;
}
This piece of css (from the Green Lume full theme) makes it gray, but only in Column layout:
.conversation.item-container:not(.item-contact):not(.read):not(.active) {
background: #292929;
}
The class for the row-layout is: item-container-row, that's why .conversation.item-container doesn't do anything here. This should do the trick:
.conversation.item-container:not(.item-contact):not(.read):not(.active),
.conversation.item-container-row:not(.item-contact):not(.read):not(.active) {
background: #292929;
}
That's great! However, has the stylesheet I've linked previously worked as expected? I believe I've experienced this whilst building the theme. 😄
Not sure, this is the first time I'm using v4 themes. I guess protonmail has changed the class item-container in the row layout or something.
Btw, I believe they added a new navigation pane in settings (e.g. on https://beta.protonmail.com/settings/appearance) which is also white in the dark theme 😉
I meant if you can paste the theme below on the appearance pane and let know if you still experience the issue please: https://raw.githubusercontent.com/csalmeida/protonmail-themes/themes-v4/themes/green_lume/green_lume_full.css 👍
Nope, didn't solve it.. But I added a Pull Request with the fixes (and a few other changes) 😁
Sorry to hear that! Could you send a screenshot of which element is affected exactly? I found that .subnav did have a white background but I assume the issue you are experiencing are with the message items themselves?
Seen on the Appearance Tab
Thank you for the pull request @laurens94! I've added a few notes. 👍
Where can I find these notes?
Here's the element, it's the message items indeed:
You need to make sure you switch to Row layout to see it:
In the Row layout there's also a white background when you have less than a screen-filling amount of emails:
