typescript support
yokyj opened this issue · comments
would you add a d.ts file to this project?
Hey @yokyj thanks for the question! We could add a .d.ts file to this project...but I thought the normal approach was to add type definitions to DefinitelyTyped for projects that aren't written in TypeScript? If you write the .d.ts & submit a pull request we'll happily add it here; just not sure if it should go over on the DefinitelyTyped repo instead? We don't use TypeScript + rosbag.js currently (a lot of our stuff is written with Flow) so we don't have any resources to maintain the type definitions at the current time, but we are always happy to review & integrate pull requests into the repo & package!
the normal approach was to add type definitions to DefinitelyTyped for projects that aren't written in TypeScript
+1. TypeScript support should probably be decoupled from the JavaScript source code. Keeping the .d.ts file in the same repository might seem handy, but as Brian mentioned, it does not make sense since TypeScript is not part of native JS.
Hello guys, I have created a pull request to DefinitelyTyped. Please have a look.
It's available as npm package
FYI the @foxglove/rosbag package has full TypeScript support.
Closed in #118