crownheightsaid / mutual-aid-app

Bug

The default error message when a 500 is returned displays __NOT_TRANSLATED__. See full context on Slack: https://crownheightsmutualaid.slack.com/archives/C014XS0BZFH/p1603995260001500

Translation file:

mutual-aid-app/src/lib/strings/locales/en/webapp.json

Line 98 in 16ee775

"errorBody": "__NOT_TRANSLATED__",

The error message is assigned here:

mutual-aid-app/src/webapp/components/DeliveryDialog/DialogScreens.js

Line 211 in 16ee775

{str("webapp:deliveryNeeded.dialog.errorBody", {

Fix

We should update errorBody with the default message. When { message } prop passed into the component is missing, use the default errorBody message, else use the message in props.

assigning myself since I added the DialogScreens file, but happy to pass on to anyone who wants to familiarize themselves with the delivery code

hey @ifearcompilererrors ! sorry to have pulled this one out from under you, but I put in a quickfix for this because it was causing some confusion for delivery volunteers this morning! 987c896. There was also a typo causing default values from being picked up from the translation file (which is another issue!). I have a follow up issue here to prevent typos in translation files: #176

[Delivery map] Display a more helpful error message when assigning delivery request

Bug

Fix