crownheightsaid / mutual-aid-app

Hey we're a mutual aid group in Crown Heights trying to help around town. Please reach out if you want to setup your own slack app and need a hand!

Fix balance comparison issues when detecting when reimbursement is complete

mjmaurer opened this issue 4 years ago · comments

Michael Maurer commented 4 years ago

https://crownheightsmutualaid.slack.com/archives/C011D4YBWHL/p1592853085112900?thread_ts=1592853085.112900&cid=C011D4YBWHL

John Sandfort commented 4 years ago

It looks like we're already using <= for this:

mutual-aid-app/src/slackapp/event-listeners/reimbursementReply.js

Line 58 in 9385eaa

newBalance <= 0

Might it be a floating point issue?

Michael Maurer commented 4 years ago

Yup! You're probably correct.