Refactor: Timetag struct without time field
stanipetrosyan opened this issue · comments
At the moment the time field is present in the Timetag structure. Is it really necessary? This field introduces really complicated methods for creating the Timetag.
In my experience I have not needed to access the Time field. Furthermore, no Timetag method uses that value to execute logic.
My proposal is to remove it and keep a single Time() method that returns the timetag transformed into time:
From
type Timetag struct {
timeTag uint64 // The acutal time tag
time time.Time
}
To
type Timetag uint64
I agree with you, it will be much better.