crev-dev / cargo-crev

A cryptographically verifiable code review system for the cargo (Rust) package manager.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Accidental changes during review

stefankreutz opened this issue · comments

I'm a bit afraid to do reviews using cargo crev crate goto because I might accidentally change files under ~/.cargo/registry/src and thus corrupt local builds. Wouldn't it be better to create and go to a temporary directory instead?

Maybe a good idea.

I wouldn't worry too much about it for now though, and IIRC cargo crev verify will warn about any "unceal" packages and cargo crev clean [<package>] will wipe them for you.

There's cargo crev open that makes a temp copy.

I thought open and goto were supposed to be the same, except one just for CLI, the other for IDE.

They don't seem to be the same. goto goes to ~/.cargo/registry/src/github.com-1ecc6299db9ec823.

Would it make sense to unify both of them so they both do a temp copy?

Yeah