creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.

Home Page:https://LegalDB.CreativeCommons.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Replace Vocabulary CDN

krysal opened this issue · comments

Problem

Currently the project is using Vocabulary via CDN, this makes it quick to start using the components but has the downside that SCSS files cannot be imported, therefore variables and mixins already defined in the library cannot be used and they have to be duplicated here.

Description

The goal is to be able to use the SCSS files of Vocabulary and make it easy to upgrade to future versions, replacing the CDN with a build process for these assets.

Implementation

  • I would be interested in implementing this feature.

I would like to work on this
But I have some confusions:

Do I need to directly download the vocabulary files in static folder and import them or use npm install with node-sass package but this will result in increased steps for Installation.I think it would be better to refactor the whole app into frontend and backend:

Frontend in Vue or React and Backend in Django-rest-framework

Hi @darkshredder, we want to avoid that two things: manually copying vocabulary files into the project and refactor the whole app (this was done recently from a Jekyll app). We want to keep dependencies low to reduce mainteinance burden, there is no a real need to use a frontend library like Vue or React for the moments.

The ideal solution I think, would be to create a pipeline process with webpack (or similar tool) to manage js dependencies with npm, something similar to what is done in the CC Open Source site.

Either way, you can send PR with your solution if you think it fits this requirements want and/or improves the development process to write styles with Vocabulary. Contributions are welcome, and thanks for your interest!