creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.

Home Page:https://LegalDB.CreativeCommons.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Feature] UI improvement

Xaid-vfx opened this issue · comments

Problem

A bad UI impression is created due to the misalignment of the navbar brand image and the navbar burger icon, which are not on the same level.

Description

The below picture represents the problem:

Screenshot 2023-03-23 at 9 43 47 PM

This can be fixed by placing both the elements in the flexbox and applying aligning properties.

Screenshot 2023-03-23 at 9 44 35 PM

The above problem persists on mobile devices.

Implementation

  • I would be interested in implementing this feature.

I am working on this.

Hey @joe-sida,
I understand you wish to work on the issue, but the issue is assigned to me. I am still working on the issue.

hi is this issue still open i would like to work on this issue

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution).

Hey,
This is Balraj,
I am willing to work on this issue can you please assign it to me
@TimidRobot

@BalrajDhakad please see the comment above yours:

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution).

Okay got it and have also read the guidelines but what does (we generally don't assign issues prior to resolution)
Can you please make it clear to me @TimidRobot

@BalrajDhakad Instead of asking for issues to be assigned, do the work and submit a pull request (PR). Even if multiple people submit PRs for the same issue, they can all list their own PRs on their GSoC application. It is the quality of work that is important, not whether it is merged.

Hi @TimidRobot, I would love to work on the issue and get it solved, can you help me with the file directory where the code is located, for the above specified issue. Thanks.

@TimidRobot I have solved this issue but I am not able to make a new PR as I have already have a PR #168 for an existing issue #153,
so can you please look through that PR so that I can open a new PR for this issue.

@TimidRobot I have solved this issue but I am not able to make a new PR as I have already have a PR #168 for an existing issue #153, so can you please look through that PR so that I can open a new PR for this issue.

you can create different PRs for different issues simultaneously using different branches.

Here are some good resources you can refer related to branching:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches
https://www.atlassian.com/git/tutorials/using-branches

Okay thanks @Xaid-vfx