creativecommons / chooser

The new and improved CC license selection tool.

Home Page:https://chooser-beta.creativecommons.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug] Missing hyperlink in Help Modal

Xaid-vfx opened this issue · comments

Description

There is an unnecessary Hyperlink in FAQ's Modal (What should I consider?). The href of this hyperlink is none and on clicking it just reopens the same website in a new Tab.

Reproduction

  1. Go to https://chooser-beta.creativecommons.org/
  2. Scroll down to CONFUSED? NEED HELP?
  3. Click on What should I consider?
  4. Click on other considerations

Expectation

Ideal solution would be to either remove the hyperlink or provide the respective link for other considerations

Screenshots

Screenshot 2023-04-04 at 12 28 32 AM

Resolution

  • I would be interested in resolving this bug.

Hii @Xaid-vfx I think its a good idea to remove the href tag or provide the respective links to the respective sites for the creator

It will be good idea if i could get the chance to write those pages under the supervision of code maintainers
and add into the sites

I would be happy to help 😊

assign this to me. I would love to take a look at the issue.

@Xaid-vfx This is a good spot, and we're grateful you pointed it out!

I spent some time and looked into this, and the hyperlink in question is not so much unecessary as its missing the correct href', which should be https://wiki.creativecommons.org/wiki/Considerations_for_licensors_and_licensees#Considerations_for_licensors

There was an error in #443 where this got missed when the Help Section content got updated.

I've updated the title of the Issue to be more accurate.

@possumbilities Working on it 🚀