creativecommons / chooser

The new and improved CC license selection tool.

Home Page:https://chooser-beta.creativecommons.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Disable scroll on body of website when modal is active.

soustab10 opened this issue · comments

Description

When a modal is active, scrolling is still active on the body of the website - which is not particularly a good user experience. It is particularly noticeable in [the terms and intended legal effect of CC0,] modal under Waiver Your Copyright.

Reproduction

  1. Step 1: Go to website .
  2. Step 2: Click on any question under CONFUSED? NEED HELP? section.
  3. Scroll and see error.

Expectation

The body should stay fixed when any modal is open.

Screenshots

Untitled.video.-.Made.with.Clipchamp.7.mp4

Environment

  • Device: Desktop Screens

Resolution

  • I would be interested in resolving this bug.
commented

@soustab10 Everything is appearing to be fine for me.Am I missing something?

@soustab10 Everything is appearing to be fine for me.Am I missing something?

I think the scroll action while the modal is active degrades the user experience. What do you think of it?

@soustab10 - https://github.com/creativecommons/chooser/pull/482
Made this PR to resolve this issue and disable scroll when the modal gets active.

if this issue is not fixed i want to fix this can you please assign me this issue?