creativecommons / chooser

The new and improved CC license selection tool.

Home Page:https://chooser-beta.creativecommons.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug] Remove hardcoded CloudFront CDN (use default Cloudflare CDN)

TimidRobot opened this issue · comments

Description

Remove hardcoded CloudFront CDN (use default Cloudflare CDN)

Reproduction

<link rel="icon" type="image/png" href="https://d15omoko64skxi.cloudfront.net/wp-content/uploads/2016/05/cc-site-icon-300x300.png" sizes="192x192">
<link rel="apple-touch-icon-precomposed" href="https://d15omoko64skxi.cloudfront.net/wp-content/uploads/2016/05/cc-site-icon-300x300.png">

Expectation

  1. Update source
    index 6e9f3a0..ab5b1db 100644
    --- public/index.html
    +++ public/index.html
    @@ -6,8 +6,8 @@
         <meta name="viewport" content="width=device-width,initial-scale=1.0">
         <meta name="description" content="Want to license your work with Creative Commons, but not sure where to start, or which license is right for you? Use our license chooser!">
         <link rel="icon" href="<%= BASE_URL %>favicon.ico">
    -    <link rel="icon" type="image/png" href="https://d15omoko64skxi.cloudfront.net/wp-content/uploads/2016/05/cc-site-icon-300x300.png" sizes="192x192">
    -    <link rel="apple-touch-icon-precomposed" href="https://d15omoko64skxi.cloudfront.net/wp-content/uploads/2016/05/cc-site-icon-300x300.png">
    +    <link rel="icon" type="image/png" href="https://creativecommons.org/wp-content/uploads/2016/05/cc-site-icon-300x300.png" sizes="192x192">
    +    <link rel="apple-touch-icon-precomposed" href="https://creativecommons.org/wp-content/uploads/2016/05/cc-site-icon-300x300.png">
         <meta name="twitter:card" content="summary" />
         <meta name="twitter:site" content="@creativecommons" />
         <meta name="twitter:creator" content="@creativecommons" />
  2. Deploy new release (not required for issue resolution)

Additional context

PR for this is blocked by npm dependency bitrot. Manual change was applied in 8b1e12e until it can be resolved.