crazy-max / WindowsSpyBlocker

Block spying and tracking on Windows

Home Page:https://crazymax.dev/WindowsSpyBlocker/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

No EOLs on simplewall files

opened this issue · comments

Hi,

I use all three simplewall files,

https://raw.githubusercontent.com/crazy-max/WindowsSpyBlocker/master/data/dnscrypt/extra.txt
https://raw.githubusercontent.com/crazy-max/WindowsSpyBlocker/master/data/dnscrypt/spy.txt
https://raw.githubusercontent.com/crazy-max/WindowsSpyBlocker/master/data/dnscrypt/update.txt

which I all merge with several other blocklists.

Unfortunately all three miss an EOL with the obvious consequence that last item gets mixed with first item of following file in the merge process.
At this time I have to add a FileAppend , \n, [FILE] in order to get things done correctly (Autohotkey scripting).

Thanks!

Hi @Cade66,

Since you do it programmatically, continue with your method.

commented

@crazy-max Just add a newline, it's not that hard...?

All lists I use include a final blank line, pity not these three.
I can manage programmatically as noted above but I have in mind those who may merge several blacklists without being aware of the possible mix (unless next file starts itself with a blank line of course).

EDIT: In fact I had encountered another blocklist which didn't end with an EOL, but the developer corrected it:

@Cade66 This is now fixed

@crazy-max , indeed. I removed the add of a blank line accordingly for all three lists and all is OK, of course.
Merging scripts could very well add an EOL to all lists of course, given the process removes them once the job is done, and that could be a pertinent caution practice, but not sure they all do (mine didn't) and that can lead to two missed items at least.
Thanks for notifying the enhancement.
I already use all three of your blocking lists in their IP version with the Windows Privacy Dashboard application, adding the three domain equivalences is an extra caution, here.
Thanks for your work, most appreciated by many, obviously.