module does not recover form md5sum error

[Herwig Bogaert]

Hi Craig
Thank you for sharing this nice module. I ran into following issue:
When there is an md5sum error, for example due to a failure in downloading the archive, the module does not retry the download during subsequent puppet runs but keeps on failing trying to run the non-existing '/usr/bin/vmware-toolbox-cmd'.
I have resolved this by adding ' refreshonly => false' to the 'download_vmwaretools' resource. This triggers a new download (and subsequent execution) of the dowload script when the vmware tools install didn't succeed during a previous run.
You might want to merge this in your code, or solve this issue in another way.
Best regards
Herwig Bogaert

[Craig Watson]

Hi,

Thanks for reporting the issue - apologies for the delay in responding!

I've fixed the issue by removing the archive with the download script if the MD5 doesn't match - it doesn't make sense to keep a bad archive anyway :)

Thanks!

[Herwig Bogaert]

Hi Craig

Thanks for the fix.

Best regards

Herwig

On Wed, Mar 5, 2014 at 1:11 PM, Craig Watson [e-mail]:

Hi,

Thanks for reporting the issue - apologies for the delay in responding!

I've fixed the issue by removing the archive with the download script if
the MD5 doesn't match - it doesn't make sense to keep a bad archive anyway
:)

Thanks!

Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-36736164
.

Herwig Bogaert
Senior Systems Engineer

VIAA - iMinds vzw* | Gaston Crommenlaan 8 box 102 | 9050 Ghent | Belgium
| www.viaa.be http://www.iminds.be*

T: [phone] | F: [phone] | M: [phone]