cpu / goacmedns

Go library to handle acme-dns client communication and persistent account storage.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Use the standard acme-dns JSON response format for storage

emilazy opened this issue · comments

commented

This is what pyacmedns does, and would allow for greater interoperability with both it and integrations that perform the registration step separately (e.g. to work around clients that can't specify allowfrom). Right now I have to use an awkward jq(1) contortion:

curl ... | jq '{
  "domain": {
    FullDomain: .fulldomain,
    SubDomain: .subdomain,
    Username: .username,
    Password: .password,
  }
}'

This should just be a matter of lowercasing the key names, though pyacmedns (and curl) will also include the allowfrom field of the response.

(Of course, the old key names should still be supported for backwards compatibility.)

👋 Hi @emilazy,

Thanks for the suggestion. It sounds sensible to me. I'll take a crack at it over the next little while.

commented

Thank you!

@emilazy Happy to help! Thanks for filing an issue.

I cut a new minor release with the fix: https://github.com/cpu/goacmedns/releases/tag/v0.0.2