Giters

cpp-linter / cpp-linter-action

A Github Action for linting C/C++ code integrating clang-tidy and clang-format to collect feedback provided in the form of file-annotations, thread-comments, workflow step-summary, and Pull Request reviews.

Home Page:https://cpp-linter.github.io/cpp-linter-action/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`lines-changed-only` should assert `files-changed-only` implicitly

2bndy5 opened this issue · comments

commented

User intuition probably implies that the lines-changed-only option should implicitly mean files-changed-only is true, but this is not the case under the hood.

I think this is partially implemented in #81 (as part of the solution to #74), but it would be better to make the source explicitly change the value of files-changed-only if lines-changed-only is not disabled.