cpp-linter workflows runs for every change
shenxianpeng opened this issue · comments
I guess your change here was to disable all cpp-linter runs only run when there is a change under docs/examples/demo/
but right now, it seems cpp-linter runs and adds comments for everything. see 7ce9dc2#comments
yes, that was the idea. But it didn't seem to work as expected. Maybe if we just remove that line, it would only run when there are changes to the demo sources.
github docs for on.<event>.path
Currently we are only using that workflow to show an example badge in the README. We don't often modify the demo sources. So, how useful it is to even have both the CI workflow and the demo sources in this repo?
yes, that was the idea. But it didn't seem to work as expected. Maybe if we just remove that line, it would only run when there are changes to the demo sources.
I think just remove it should be work.
We should also disable thread-comments for that workflow. That way we are less bothered by the posted comment.
Currently we are only using that workflow to show an example badge in the README. We don't often modify the demo sources. So, how useful it is to even have both the CI workflow and the demo sources in this repo?
Right. leave it there could as user's actual example and an example badge
It might be getting triggered from master branch not main branch.
Oh, I see. Actually, the comment comes from the test CI workflow which calls the test repo's reusable workflow.
So, maybe we don't run the test CI on push events?
So, maybe we don't run the test CI on push events?
That should be fine.
yep. that fixed it 🎉