State what python version is used in README
2bndy5 opened this issue · comments
One thing that would be nice to have in the README is that Python 3.10 needs to be installed in the docker image; that would extend the requirements and make it easier to understand.
Originally posted by @carlosala in #184 (comment) (edited for context by 2bndy5)
This information is exclusive to workflows that use docker images not maintained by GitHub. GitHub-maintained docker images (ubuntu-latest, windows-latest, and macos-latest) are already well enough equipped.
A stupid question, why do you have to specify version 3.11? because of this line?
Line 119 in 455f328
What happens if other version?
Yep, setup-python as is set up only creates the structure and the binary is used afterwards, but it needs to have libpython3.11, for example, that should be installed in the system.
I just went with 3.11 because 3.12 recently turned "stable". For now, I have no reason to change that.
I suppose we could switch to whatever version ships with Ubuntu latest LTS release (which I think is currently 3.10).
Yep, latest LTS release is 3.10 https://packages.ubuntu.com/jammy/python3
@shenxianpeng Any objections to changing python version to follow Ubuntu latest LTS? It tends to change every couple years in April.
@carlosala would that be preferable?
Much better, yes.
No, looks good to me